Putting BSP under the project directory does not work due to bug in bsp.cmake

[vedecoid]

When using the EXPLICIT_LOCATION option in the find_bsp function, that location is not taken as the BSP_ROOT when there is any managed BSP defined. As such the function ‘copy BSP to project’ does not work. It copies the BSP but still references the original one.

The root cause of the fault is an error in bsp.cmake.

At line 204, the following code never identifies the need to set _load_regular_bsps back to zero if BSP_EXPLICIT_LOCATION is defined, as it should, if VISUALGDB_COMPONENT_LISTS_DIR is not empty (which is never the case if BSPs have been downloaded)

set(_load_regular_bsps 1)

if((NOT ("${BSP_EXPLICIT_LOCATION}" STREQUAL "")) OR (NOT ("${BSP_SOURCE}" STREQUAL "")))
if("${VISUALGDB_COMPONENT_LISTS_DIR}" STREQUAL "")
set(_load_regular_bsps 0)
endif()
endif()

Resetting _load_regular_bsps to zero when debugging does load the correct local BSP

Please correct this error in the regular bsp.cmake. I’ve changed it manually for my install, but this will likely break again when doing an upgrade.

[vedecoid]

Changing the code to the snippet below seems to correct the error (although I haven’t used it enough to detect potential undesirable side effects)

if(NOT ("${BSP_EXPLICIT_LOCATION}" STREQUAL ""))
   set(_load_regular_bsps 0)
else()
   if((NOT ("${BSP_SOURCE}" STREQUAL "")))
     if("${VISUALGDB_COMPONENT_LISTS_DIR}" STREQUAL "")
       set(_load_regular_bsps 0)
     endif()
   endif()
endif()

[Author]

Posts